Feat.add e2e test for maps no trigger #1597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add flodds no-trigger reset flow Add POM locators, testData & dev country switcher Change test names & locators selection Add waitForLoadState Add component object, testid & assert header function Add TopBarComponent object & expect assert method Add ChatComponent POM & assertions fo no-trigger Add AggregateComponent POM & assertions Add MapComponent POM & assertions Add comments and timeout Move test and add force click Add additional click add timeout test add angualr attribute and change data test ids remove redundant waits Create a base for the test Fix typos and add breadCrumb is visible function and testIds Add legend open true or false assertion and data-testid for legend Add layer-menu test id and assertion for Layers to be hidden by default
Piotrk39
force-pushed
the
feat.add-e2e-test-for-maps-no-trigger
branch
from
725b690 to
5843e08
Compare
3 tasks
gulfaraz
approved these changes
Oct 2, 2024
There was a problem hiding this comment.
Looks good! No blocking comments. Great work @Piotrk39
> [email protected] test
> playwright test
Running 2 tests using 1 worker
✓ 1 [chromium] › Dashboard/AllElementsPresentNoTrigger.spec.ts:40:5 › [30509] All Dashboard elements are present in no-trigger mode (9.8s)
✓ 2 [chromium] › Map/AllMapComponentsPresentNotrigger.spec.ts:37:5 › [30538] All Map elements are present in no-trigger mode (9.4s)
2 passed (20.4s)
interfaces/IBF-dashboard/src/app/components/disaster-type/disaster-type.component.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds E2E test for validating front-end elements of map component are loaded and presented properly.
Checklist before requesting a review
Notes for the reviewer