Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test and assertions #1624

Merged
merged 3 commits into from
Oct 7, 2024
Merged

Conversation

Piotrk39
Copy link
Contributor

@Piotrk39 Piotrk39 commented Oct 3, 2024

Describe your changes

Adds test of Disaster Type component's elements

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@Piotrk39 Piotrk39 marked this pull request as ready for review October 3, 2024 12:09
}

async topBarComponentIsVisible() {
const topBar = this.topBar;
await expect(topBar).toBeVisible();
}

async allDisasterTypeElementsArePresent() {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will fail for other countries where different hazards are enabled. This is good for now but good to know this when you run the same tests for a different login.

@Piotrk39 Piotrk39 merged commit e39be19 into master Oct 7, 2024
8 checks passed
@Piotrk39 Piotrk39 deleted the feat.add-e2e-for-top-bar-no-trigger branch October 7, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants