Feat.add e2e test for aggregates section #1626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gulfaraz
changed the base branch from
master
to
feat.add-e2e-test-for-chat-section-no-trigger
gulfaraz
approved these changes
Oct 7, 2024
| const layerCount = await this.aggregatesLayerRow.count(); | ||
| const iconLayerCount = await this.aggregatesInfoIcon.count(); | ||
| // Basic Assertions | ||
| expect(headerTextModified).toBe('National View 0 Predicted Flood(s)'); |
There was a problem hiding this comment.
This will be different for other countries and hazards. It's good for now. We should run these tests for other countries in the next month to see what is different.
| @@ -3,22 +3,73 @@ import { Locator, Page } from 'playwright'; | |||
|
|
|||
| import DashboardPage from './DashboardPage'; | |||
|
|
|||
| const expectedLayersNames = [ | |||
There was a problem hiding this comment.
It's good that this list is outside the logic. This list varies depending on country and hazard.
Base automatically changed from
feat.add-e2e-test-for-chat-section-no-trigger
to
master
October 7, 2024 18:20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Adds assertions for all elements in Aggregates section.
Checklist before requesting a review