Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: area speech bbubble appears twice #1632

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Oct 8, 2024

Describe your changes

PR resolves #1575.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. First observation is that this bug derives from our mock setup, where all mock data for all admin-areas is repeated for every event, instead of trimming down each event's mock data to only the admin-areas of that event. The reason for this is because it's easier this way, because we'd have to go through all the mock files to do this trimming. Still, it would be better to do that. This same situation should not occur in production, because there the pipeline will actually only upload the admin-areas belonging to that event.
  2. That being said, this can and should also additionally be solved by filtering in the GET query code on event if available. This solves the issue, and is the better fix anyway. So opting to not also clean up the mock data. Feel free to disagree.

@arsforza arsforza self-requested a review October 14, 2024 08:47
@jannisvisser jannisvisser merged commit 60a7a2b into master Oct 14, 2024
8 checks passed
@jannisvisser jannisvisser deleted the fix.area-speech-bubble-appears-twice branch October 14, 2024 09:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] chat bubble 3 time the same
2 participants