Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not send any mock exposure data when leadTime > 3 months #1653

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Oct 14, 2024

Describe your changes

Resolves bug 859

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. I basically reversed the previous edit on this same line of code, which was - according to the commit message - done to fix ZWE mock. But this code is within an IF, which specifically excludes ZWE.
  2. So I reversed it and checked both for Ethiopia (fixes the bug) and for Zimbabwe (still works fine).
  3. This is a mock only bug. Production pipeline should take care of not sending any data for more than 3 months leadTime.

@gulfaraz gulfaraz self-requested a review October 15, 2024 07:33
@arsforza arsforza requested review from arsforza and removed request for gulfaraz October 15, 2024 14:47
@jannisvisser jannisvisser merged commit e74290b into master Oct 15, 2024
8 checks passed
@jannisvisser jannisvisser deleted the fix.mock-drought-far-leadtimes-enabled branch October 15, 2024 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants