test: remove CUSTOM SCHEMA warnings #1713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@gulfaraz what is the point of the 'note to the reviewer' above? Do you mean to do this in this PR still? Or do you create a follow-up note/issue? |
I apologize for the lack of clarity @jannisvisser. The note was to flag that there are skipped tests. If this is known information then you can ignore the note.
No. I will add follow-up issues to unskip the tests. For additional context, these changes are a follow-up of a call with @arsforza to continue testing. |
jannisvisser
approved these changes
Oct 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Removes warnings in frontend tests.
Notes for the reviewer
I noticed 2 tests are skipped using
xit. These need to be unskipped and the errors resolved.