Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix.email typhoon copy #1784

Merged
merged 4 commits into from
Nov 18, 2024
Merged

Fix.email typhoon copy #1784

merged 4 commits into from
Nov 18, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Nov 12, 2024

Describe your changes

Resolves issue 908

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. I went for a pretty blunt overwriting of the generic ux copy in case of typhoon for now. But otherwise it got even more confusing, mixing up partly generic with partly specific code.
  2. Added new API-tests per typhoon scenario.
  3. Note that the mock sccenarios / API-tests do not cover all possible scenarios. E.g. all the noLandfall/noLandfallYet/afterLandfall are all trigger (not warning). Also the afterLandfall event is landfall (not no-landfall). So maybe check for those cases extra carefully. (Maybe document in code which cases are covered in mock/api and which not?)

@jannisvisser jannisvisser merged commit c5f4527 into master Nov 18, 2024
8 checks passed
@jannisvisser jannisvisser deleted the fix.email-typhoon-copy branch November 18, 2024 15:37
@jannisvisser
Copy link
Contributor Author

@gulfaraz just FYI'ing so you're aware.

@gulfaraz
Copy link
Member

Looks good @jannisvisser. It's nice that you also added tests for these changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants