Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: typhoon-track back-end unit and integration tests #1831

Merged
merged 11 commits into from
Dec 23, 2024

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Dec 3, 2024

Describe your changes

  • I combined both PBIs / types of tests in this PR as I approached them together.
  • See this devops task for explanation on what is tested how.
  • Also in general see potential context in tasks.
  • I changed 'beforeEach' to 'beforeAll' in all integration tests, which saves considerable time. Given that we already use 'removeEvents=true' in the mocking, we don't need to reset for every test. But in the future, always keep checking what makes sense.
  • I duplicated all necessary dtos/enums now in a specific folder within tests/integration. Going forward if we need more and more of this, I'm still not convinced personally this is the best idea. But so be it for now.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@jannisvisser jannisvisser marked this pull request as draft December 3, 2024 16:20
@jannisvisser jannisvisser marked this pull request as ready for review December 9, 2024 15:34
@jannisvisser jannisvisser changed the title chore: move tests into own folder test: typhoon-track back-end unit and integration tests Dec 11, 2024
@gulfaraz gulfaraz force-pushed the test.integration-typhoon-track branch from 5f1f422 to cc6767d Compare December 23, 2024 12:59
@gulfaraz gulfaraz merged commit 79c681e into master Dec 23, 2024
8 checks passed
@gulfaraz gulfaraz deleted the test.integration-typhoon-track branch December 23, 2024 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants