Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: connect dynamic data to active assets #1851

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

jannisvisser
Copy link
Collaborator

Describe your changes

Bug identified after release to production, where dynamic point data is connected old (active: false) points. Was identified for gauges, but could also happen for other points/lines with overlapping fid's between old and new data.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. Any helpful instructions or clarifications...

Sorry, something went wrong.

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@jannisvisser
Copy link
Collaborator Author

merging because hotfix needed quickly

@jannisvisser jannisvisser merged commit dd54369 into master Dec 11, 2024
6 checks passed
@jannisvisser jannisvisser deleted the fix.upload-gauge-data branch December 11, 2024 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant