Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat.setup lesotho #1899

Merged
merged 13 commits into from
Jan 10, 2025
Merged

Feat.setup lesotho #1899

merged 13 commits into from
Jan 10, 2025

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Jan 6, 2025

Describe your changes

Brief description of your changes - not in-depth because the bulk of the description should be in the task on DevOps.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Notes for the reviewer

  1. Any helpful instructions or clarifications...

Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Most of the changes are minor refactors and mock data.
  2. Lesotho is added as planned with empty mock data.
  3. I could not infer drought behaviour from the code.
  4. I didn't load the drought scenarios bcoz I should understand drought better to know what to test.

Nice work, the comments help a lot with the review!

@jannisvisser jannisvisser merged commit 3aa7194 into master Jan 10, 2025
7 checks passed
@jannisvisser jannisvisser deleted the feat.setup-lesotho branch January 10, 2025 12:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants