Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: jwt expiry #1907

Merged
merged 2 commits into from
Jan 10, 2025
Merged

fix: jwt expiry #1907

merged 2 commits into from
Jan 10, 2025

Conversation

gulfaraz
Copy link
Member

@gulfaraz gulfaraz commented Jan 9, 2025

Describe your changes

Resolves AB#31743 by,

  1. Catch token verification error in the API service.
  2. Check for expired tokens on the dashboard.

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@gulfaraz gulfaraz requested a review from jannisvisser January 9, 2025 17:57
Copy link
Contributor

@jannisvisser jannisvisser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! great to get this resolved. I never realized before this also had a end-user effect, but clearly it did in retrospect. Good to get this released soon. (But waiting for sprint planning on tuesday to put release item in sprint is good enough).

@jannisvisser jannisvisser merged commit 842c2bc into master Jan 10, 2025
7 checks passed
@jannisvisser jannisvisser deleted the fix.jwt-expiry branch January 10, 2025 12:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants