Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove backend stop-trigger code #1936

Merged
merged 3 commits into from
Feb 3, 2025

Conversation

jannisvisser
Copy link
Collaborator

@jannisvisser jannisvisser commented Jan 24, 2025

Describe your changes

  • Remove enableStopTrigger.
  • All other backend stop-trigger code is kept to repurpose to 'manual trigger' soon.
  • Front-end code was already removed earlier

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Sorry, something went wrong.

@jannisvisser jannisvisser force-pushed the chore.remove-stop-trigger-backend branch from 9acffaf to 3e37c41 Compare January 24, 2025 08:53
@jannisvisser jannisvisser force-pushed the chore.remove-stop-trigger-backend branch from 3e37c41 to 36bb8db Compare January 24, 2025 09:38
@jannisvisser jannisvisser changed the title chore: remove enableStopTrigger AB#32660 chore: remove backend stop-trigger code Jan 28, 2025
Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on the description in this task.

@jannisvisser jannisvisser merged commit bbd0365 into master Feb 3, 2025
7 checks passed
@jannisvisser jannisvisser deleted the chore.remove-stop-trigger-backend branch February 3, 2025 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants