Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: entities #1938

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

refactor: entities #1938

wants to merge 10 commits into from

Conversation

jannisvisser
Copy link
Contributor

@jannisvisser jannisvisser commented Jan 24, 2025 •
edited by azure-boards bot
Loading

Describe your changes

This PR addresses:

  1. Create endpoint for adding/updating disaster entities (incl BE unit test): AB#32987
  2. Remove leadtime entity in favour of existing enum: AB#32985
  3. Remove area-of-focus entity in favour of new const: AB#32986
  4. Some additional typing / removing unused code based on lint warings: AB#32995

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

@jannisvisser jannisvisser marked this pull request as draft January 24, 2025 10:33
@jannisvisser jannisvisser changed the title refactor: use leadTime enum instead of entity refactor: entities Jan 27, 2025
@jannisvisser jannisvisser marked this pull request as ready for review January 27, 2025 12:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jannisvisser