Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: filter admin-areas on eventName AB#33076 #1946

Merged
merged 2 commits into from
Jan 29, 2025
Merged

fix: filter admin-areas on eventName AB#33076 #1946

merged 2 commits into from
Jan 29, 2025
+18 −0

Conversation

jannisvisser
Copy link
Collaborator

@jannisvisser jannisvisser commented Jan 28, 2025 •
edited by azure-boards bot
Loading

Describe your changes

See AB#33076

Checklist before requesting a review

  • I have performed a self-review of my code
  • I have added tests wherever relevant
  • I have made sure that all automated checks pass before requesting a review

Sorry, something went wrong.

@jannisvisser
fix: filter admin-areas on eventName AB#33076

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
18c9760
@jannisvisser
fix: filter for eventName at more places

Partially verified

This commit is signed with the committer’s verified signature.
spydon’s contribution has been verified via GPG key.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
Loading
Loading status checks…
f766101
gulfaraz
gulfaraz approved these changes Jan 29, 2025
View reviewed changes
Copy link
Member

@gulfaraz gulfaraz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jannisvisser jannisvisser merged commit de30b18 into master Jan 29, 2025
7 checks passed
@jannisvisser jannisvisser deleted the fix.filter-admin-areas-eventname branch January 29, 2025 08:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gulfaraz gulfaraz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

AB#33076
2 participants
@jannisvisser @gulfaraz