Merge pull request #246 from njam/issue-246

Installation of modules without metadata nor modulefile fails
rodjek · Aug 8, 2014 · 3416850 · 3416850
2 parents 08eb2c1 + 83e928c
commit 3416850
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 2 deletions.
diff --git a/features/install.feature b/features/install.feature
@@ -40,3 +40,13 @@ Feature: cli/install
     """
     Unable to parse .*/bad_modulefile/Modulefile, ignoring: Missing version
     """
+
+  Scenario: Running install with no Modulefile nor metadata.json
+    Given a file named "Puppetfile" with:
+    """
+    forge "http://forge.puppetlabs.com"
+
+    mod 'puppetlabs/stdlib', :git => 'https://github.com/puppetlabs/puppetlabs-stdlib.git', :ref => '3.0.0'
+    """
+    When I run `librarian-puppet install`
+    Then the exit status should be 0
diff --git a/lib/librarian/puppet/source/local.rb b/lib/librarian/puppet/source/local.rb
@@ -118,8 +118,9 @@ def parsed_metadata
               end
             }
           else
-            warn { "Could not find metadata.json nor Modulefile at #{filesystem_path}" }
-            {}
+            {
+              'dependencies' => []
+            }
           end
           @metadata
         end
-Original file line number
+Diff line change
@@ Expand Up / @@ -118,8 +118,9 @@ def parsed_metadata @@
                   end
                 }
               else
-                warn { "Could not find metadata.json nor Modulefile at #{filesystem_path}" }
-                {}
+                {
+                  'dependencies' => []
+                }
               end
               @metadata
             end
@@ Expand Down @@