Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for Ubuntu 14.04 LTS #32

Closed
wants to merge 1 commit into from
Closed

Add support for Ubuntu 14.04 LTS #32

wants to merge 1 commit into from

Conversation

blkperl
Copy link

@blkperl blkperl commented Mar 24, 2014

No description provided.

@jchonig
Copy link

jchonig commented Jun 10, 2014

I'm also having this issue and looked at the provided patch.

The fix of making a template out of logrotate.conf.erb looks good.

It might be more general to put tests in the os-specific classes (logrotate::defaults::debian for example) for OS versions that use the new version of logrotate.

Thoughts from rodjek?

Thanks.

Jeff

wolfspyre pushed a commit to wolfspyre/puppet-logrotate that referenced this pull request Jul 9, 2014
@rmnwolf
[EOPS-6067] manually add in fixes from rodjek#32
af0b6f9
rodjek
rodjek reviewed Sep 21, 2014
View reviewed changes
templates/etc/logrotate.conf.erb
@@ -5,6 +5,12 @@
# rotate log files weekly
weekly

<% if @lsbmajdistrelease and (scope.function_versioncmp([@lsbmajdistrelease, '14']) >= 0) -%>
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should also check lsbdistid to ensure that this only applies to Ubuntu > 14.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do I need to check both?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@rodjek Ping

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You want to check both to insure that this change doesn't happen on distros other than Ubuntu. I.e. this would incorrectly be applied to Fedora releases > 14.

@b4ldr b4ldr mentioned this pull request Oct 21, 2014
Closed
@luxflux
Copy link

luxflux commented Nov 22, 2014

Whats the state here?

@b4ldr b4ldr mentioned this pull request Dec 2, 2014
Closed
@benjfield
Copy link

Looks good, I too have this issue and I am currently having to use this branch.

geoffdavis pushed a commit to UCSD-ANF/puppet-logrotate that referenced this pull request Feb 3, 2017
@robinbowes
Merge pull request rodjek#32 from syseleven/fix_puppet_lint_issues
5d68916 
Fix puppet-lint issues and bad style
@blkperl
Copy link
Author

blkperl commented Sep 15, 2017

Closing. I don't have time to address feedback

@blkperl blkperl closed this Sep 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@blkperl @jchonig @luxflux @benjfield @rodjek