Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve AsyncState #355

Merged
merged 7 commits into from
Dec 2, 2024
Merged

Conversation

mcmah309
Copy link
Contributor

@mcmah309 mcmah309 commented Dec 1, 2024

closes #351

merge #354 first

@mcmah309 mcmah309 changed the title Improve async state Improve AsyncState Dec 1, 2024
@mcmah309 mcmah309 mentioned this pull request Dec 1, 2024
Copy link

codecov bot commented Dec 1, 2024

Codecov Report

Attention: Patch coverage is 78.57143% with 21 lines in your changes missing coverage. Please review.

Project coverage is 83.84%. Comparing base (dd5c6ec) to head (c6cff56).
Report is 126 commits behind head on main.

Files with missing lines Patch % Lines
packages/signals_core/lib/src/async/state.dart 77.41% 21 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main     #355       +/-   ##
===========================================
- Coverage   98.82%   83.84%   -14.99%     
===========================================
  Files          38       60       +22     
  Lines        1196     2557     +1361     
===========================================
+ Hits         1182     2144      +962     
- Misses         14      413      +399     
Files with missing lines Coverage Δ
packages/signals_core/lib/src/async/signal.dart 100.00% <100.00%> (ø)
packages/signals_core/lib/src/core/computed.dart 97.39% <100.00%> (-0.39%) ⬇️
packages/signals_core/lib/src/core/signal.dart 98.50% <ø> (+1.53%) ⬆️
packages/signals_core/lib/src/async/state.dart 86.06% <77.41%> (-13.94%) ⬇️

... and 31 files with indirect coverage changes

@rodydavis
Copy link
Owner

LGTM!

@rodydavis rodydavis merged commit 5063541 into rodydavis:main Dec 2, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve AsyncState
2 participants