Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use oldest-supported-numpy as build requirements #9

Merged
merged 1 commit into from
Feb 2, 2021

Conversation

xmatthias
Copy link
Contributor

use oldest-supported-numpy for build requirements.
Explanation: pypa/pip#9542 (comment)

Otherwise due to a pip-bug, at build time, the latest numpy is installed, which can break if the environment uses a older pinned version.

in pypa/pip#9542, I've posted a snippet to recreate the faulty behavior with the current version.
As proposed there, using oldest-supported-numpy should fix this, as older binaries work with newer versions:

The reason to use the oldest available Numpy version as a build-time dependency is because of ABI compatibility. Binaries compiled with old Numpy versions are binary compatible with newer Numpy versions, but not vice versa.

Source

Otherwise due to a pip-bug, at build time, the latest numpy is installed, which can break if the environment uses a older pinned version
Explanation: pypa/pip#9542 (comment)
@roebel roebel merged commit 7b944b3 into roebel:master Feb 2, 2021
@roebel
Copy link
Owner

roebel commented Feb 2, 2021

Thanks for the suggestion.

@xmatthias xmatthias deleted the patch-1 branch February 2, 2021 12:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants