Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add mutex to in band runner #7

Merged
merged 2 commits into from
Apr 27, 2018
Merged

feat: add mutex to in band runner #7

merged 2 commits into from
Apr 27, 2018

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Mar 27, 2018

Same as #5, but for #6.

@@ -42,36 +42,39 @@ const createRunner = runPath => {
onFailure,
options,
) {
const mutex = throat(1);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Member

@rogeliog rogeliog left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NIT: Changelog?

@SimenB
Copy link
Member Author

SimenB commented Mar 30, 2018

Could use semantic release :D But yeah I'll update it

* Initial Release
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea what's up, I edited in the GitHub UI. probably added a trailing newline

Copy link

@keplersj keplersj Mar 30, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IIRC it does trailing newlines by default.

@SimenB SimenB merged commit 5b22819 into master Apr 27, 2018
@SimenB SimenB deleted the mutext-in-band branch April 27, 2018 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants