Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run CI tests against Rails 7.2 #394

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,8 @@ jobs:

gemfile:
- Gemfile
- gemfiles/rails_edge.gemfile # 7.2.0.alpha
- gemfiles/rails_edge.gemfile # 8.0
- gemfiles/rails_7.2.gemfile
- gemfiles/rails_7.1.gemfile
- gemfiles/rails_7.0.gemfile
- gemfiles/rails_6.1.gemfile
Expand All @@ -50,16 +51,25 @@ jobs:
# NOTE(ivy): Rails 7 requires Ruby version >= 2.7
- ruby: jruby-9.3
gemfile: gemfiles/rails_edge.gemfile
- ruby: jruby-9.3
gemfile: gemfiles/rails_7.2.gemfile
- ruby: jruby-9.3
gemfile: gemfiles/rails_7.1.gemfile
- ruby: jruby-9.3
gemfile: gemfiles/rails_7.0.gemfile
- ruby: jruby-9.2
gemfile: gemfiles/rails_edge.gemfile
- ruby: jruby-9.2
gemfile: gemfiles/rails_7.2.gemfile
- ruby: jruby-9.2
gemfile: gemfiles/rails_7.1.gemfile
- ruby: jruby-9.2
gemfile: gemfiles/rails_7.0.gemfile
# NOTE: Rails 7.2 requires Ruby version >= 3.1
- ruby: "2.7"
gemfile: gemfiles/rails_7.2.gemfile
- ruby: "3.0"
gemfile: gemfiles/rails_7.2.gemfile
# NOTE: Rails edge requires Ruby version >= 3.1
- ruby: "2.7"
gemfile: gemfiles/rails_edge.gemfile
Expand Down
1 change: 1 addition & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -3,5 +3,6 @@
Gemfile.lock
coverage
gemfiles/*.lock
gemfiles/vendor
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝 [chore] I needed to run BUNDLE_GEMFILE=gemfiles/rails_7.2.gemfile bundle to debug test failures but it creates files under gemfiles/vendor. So I decided to let it ignore them.

pkg/*
vendor/bundle
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -49,9 +49,9 @@ default, instead it assumes you use a proper log formatter instead.
Lograge is actively tested against current and officially supported Ruby and
Rails releases. That said, Lograge _should_ work with older releases.

- [Rails](https://endoflife.date/rails): Edge, 6.1, 6.0, 5.2
- [Rails](https://endoflife.date/rails): Edge, 7.2, 7.1, 7.0, 6.1, 6.0, 5.2
- Rubies:
- [MRI](https://endoflife.date/ruby): HEAD, 3.1.0-preview1, 3.0, 2.7, 2.6
- [MRI](https://endoflife.date/ruby): HEAD, 3.2, 3.1, 3.0, 2.7, 2.6
- JRuby: HEAD, 9.2, 9.1
- TruffleRuby: HEAD, 21.3

Expand Down
19 changes: 19 additions & 0 deletions gemfiles/rails_7.2.gemfile
Original file line number Diff line number Diff line change
@@ -0,0 +1,19 @@
# frozen_string_literal: true

source 'https://rubygems.org'

# Specify your gem's dependencies in lograge.gemspec
gemspec path: '..'

group :test do
gem 'actionpack', '~> 7.2.0'
gem 'activerecord', '~> 7.2.0'
# logstash does not release any gems on rubygems, but they have two gemspecs within their repo.
# Using the tag is an attempt of having a stable version to test against where we can ensure that
# we test against the correct code.
gem 'logstash-event', git: 'https://github.com/elastic/logstash', tag: 'v1.5.4'
# logstash 1.5.4 is only supported with jrjackson up to 0.2.9
gem 'jrjackson', '~> 0.2.9', platforms: :jruby
gem 'lines'
gem 'thread_safe'
end