Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add onlyRelativePath option to node-roikoren/no-missing-{import,require} rules #14

Merged
merged 4 commits into from
Dec 2, 2021

Conversation

roikoren755
Copy link
Owner

Summary

Issues

@changeset-bot
Copy link

changeset-bot bot commented Nov 28, 2021

🦋 Changeset detected

Latest commit: 90b3931

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
eslint-plugin-node-roikoren Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@codecov
Copy link

codecov bot commented Nov 28, 2021

Codecov Report

Merging #14 (90b3931) into main (a474741) will increase coverage by 0.00%.
The diff coverage is 93.75%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main      #14   +/-   ##
=======================================
  Coverage   91.32%   91.33%           
=======================================
  Files          64       65    +1     
  Lines        1314     1327   +13     
  Branches      269      272    +3     
=======================================
+ Hits         1200     1212   +12     
  Misses         41       41           
- Partials       73       74    +1     
Impacted Files Coverage Δ
src/util/get-only-relative-path.ts 88.88% <88.88%> (ø)
src/rules/no-missing-import.ts 100.00% <100.00%> (ø)
src/rules/no-missing-require.ts 100.00% <100.00%> (ø)
src/util/check-existence.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a474741...90b3931. Read the comment docs.

@sonarqubecloud
Copy link

sonarqubecloud bot commented Dec 2, 2021

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.7% 5.7% Duplication

@roikoren755 roikoren755 merged commit 78e3c28 into main Dec 2, 2021
@roikoren755 roikoren755 deleted the only-relative-path branch December 2, 2021 14:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant