This repository has been archived by the owner on Jul 22, 2023. It is now read-only.
Add functionalities to Vector3 and Vector3int16 #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @LPGhatguy I want to submit more implementation of types like these, should I pile them up in a single PR or one or two type per PR? |
|
Keeping the types to one or two per PR would be much preferred. My backlog is clogged up right now and they're way easier to review that way! |
LPGhatguy
suggested changes
May 7, 2021
LPGhatguy
approved these changes
May 7, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Vector3 value support and also improves Vector3int16 to match features