In the plugin, don't write properties if they're nil and also a number #955
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When sent through the network, NaN and Infinity become
nil
due to JSON not supporting them. This results in two problems:value of type nil cannot be converted to number
warning in the output0
instead of whatever value it was beforeNeither of these are desirable, so this PR fixes that behavior. It does so by explicitly ignoring
nil
updates forFloat32
andFloat64
updates. This is explicitly on the 7.4.x branch because I don't want it to become permanent. Long-term, we want to swap to a different network protocol which should fix this issue.See #953 for some discussion on this subject.