Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rokit does not always gracefully handle invalid manifests #12

Closed
filiptibell opened this issue Apr 23, 2024 · 0 comments · Fixed by #15
Closed

Rokit does not always gracefully handle invalid manifests #12

filiptibell opened this issue Apr 23, 2024 · 0 comments · Fixed by #15
Assignees
Labels
bug Something isn't working

Comments

@filiptibell
Copy link
Collaborator

Rokit sometimes indexes directly into TOML documents, which may panic if no value exists for the key, example:

https://github.com/filiptibell/rokit/blob/d41b102f40cb7d58c083803d540d154a7e4ea645/lib/manifests/rokit.rs#L91-L94

self.document["tools"] will panic here if the user has manually written an empty Rokit manifest, accidentally deleted / renamed the tools section, etc.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant