Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle manifests with missing tools section more gracefully #15

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

filiptibell
Copy link
Collaborator

This PR closes #12 by properly checking if the [tools] section exists before further reading of Rokit manifests.

@kennethloeffler
Copy link
Member

LGTM - are there possibly other places where TOML documents are indexed directly?

@filiptibell
Copy link
Collaborator Author

filiptibell commented Apr 23, 2024

are there possibly other places where TOML documents are indexed directly?

Not to my knowledge - Aftman manifests use serde, Foreman's manifest and Rokit's auth manifest both look fine. Those should be all of the other manifests we deserialize / index into. I did a quick grep to make sure as well.

@filiptibell filiptibell merged commit e9008a8 into main Apr 23, 2024
10 checks passed
@kennethloeffler kennethloeffler deleted the fix-manifest-panics branch April 23, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rokit does not always gracefully handle invalid manifests
2 participants