-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display update changelog if requested on self-update
#56
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, this will be a great improvement in UX for updating! I'm not familiar with the libraries used here but they look fine to me.
I am slightly concerned about the diff in Cargo.lock
though - it seems like it is pulling in large dependencies such as image
, an svg renderer, openssl, and some others that we don't need for basic changelogs in the terminal. We probably need to disable some features in these new deps 🤔
I played around with the features for mdcat - but it doesn't improve the changes in Cargo.lock much. There aren't any features on mdcat to disable HTTP requests either. By itself, mdcat isn't much of a library, but more of a CLI tool, which has a library interface too. I can probably swap it out for another markdown renderer, but I've not found any other alternatives to have satisfactory render outputs. |
It seems like |
I currently am already disabling its features - but I'll try seeing if using it as a direct rather than peer dependency makes any difference. |
Yeah, you'll have to remove |
* Now directly uses pulldown-cmark-mdcat instead of using mdcat's exported wrapper for it * Updated pulldown-cmark-mdcat to v2.3.0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍 just need the conflict resolved
This can potentially be expanded to display changelogs for updates on all tools, rather than just Rokit itself.
Closes #19.