Update wrong host password error message (#134)

* Update wrong host password error message * Fix unit test to look for the updated message * Get 100% code coverage
rokucommunity · Dec 14, 2023 · 1ca7f51 · 1ca7f51
1 parent 06cd6e7
commit 1ca7f51
Show file tree

Hide file tree

Showing 2 changed files with 18 additions and 2 deletions.
diff --git a/src/RokuDeploy.spec.ts b/src/RokuDeploy.spec.ts
@@ -1048,14 +1048,29 @@ describe('index', () => {
             });
         });
 
+        it('checkRequest handles edge case', () => {
+            function doTest(results, hostValue = undefined) {
+                let error: Error;
+                try {
+                    rokuDeploy['checkRequest'](results);
+                } catch (e) {
+                    error = e as any;
+                }
+                expect(error.message).to.eql(`Unauthorized. Please verify credentials for host '${hostValue}'`);
+            }
+            doTest({ body: 'something', response: { statusCode: 401, request: { host: '1.1.1.1' } } }, '1.1.1.1');
+            doTest({ body: 'something', response: { statusCode: 401, request: { host: undefined } } });
+            doTest({ body: 'something', response: { statusCode: 401, request: undefined } });
+        });
+
         it('rejects when response contains invalid password status code', () => {
             options.failOnCompileError = true;
             mockDoPostRequest('', 401);
 
             return rokuDeploy.publish(options).then(() => {
                 assert.fail('Should not have succeeded due to roku server compilation failure');
             }, (err) => {
-                expect(err.message).to.equal('Unauthorized. Please verify username and password for target Roku.');
+                expect(err.message).to.be.a('string').and.satisfy(msg => msg.startsWith('Unauthorized. Please verify credentials for host'));
                 expect(true).to.be.true;
             });
         });

diff --git a/src/RokuDeploy.ts b/src/RokuDeploy.ts
@@ -657,7 +657,8 @@ export class RokuDeploy {
         }
 
         if (results.response.statusCode === 401) {
-            throw new errors.UnauthorizedDeviceResponseError('Unauthorized. Please verify username and password for target Roku.', results);
+            const host = results.response.request?.host?.toString?.();
+            throw new errors.UnauthorizedDeviceResponseError(`Unauthorized. Please verify credentials for host '${host}'`, results);
         }
 
         let rokuMessages = this.getRokuMessagesFromResponseBody(results.body);