Identify when a 577 error is thrown, send a new developer friendly message #180
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TwitchBronBron
approved these changes
Nov 21, 2024
Co-authored-by: Bronley Plumb <[email protected]>
src/RokuDeploy.ts
Outdated
| } catch (installError: any) { | ||
| switch (installError.results.response.statusCode) { | ||
| case 577: | ||
| throw new errors.DeviceFailedConnectionError(); |
There was a problem hiding this comment.
Pass in the installError and set it as .cause on the new error
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Error/cause
There was a problem hiding this comment.
Our Error type is this:
interface Error { name: string; message: string; stack?: string; }
I just added the .cause to the new Error type so that it can be passed in.
Let me know if that is sufficient.
TwitchBronBron
approved these changes
Nov 25, 2024
… error as the cause so developers can trace back to the root cause of the error
TwitchBronBron
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.