-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding ability to autogenerate "hello world" template for new developers #621
base: master
Are you sure you want to change the base?
Conversation
Adds the ability to create a new roku hello world project through the extension
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small initial pass of review. Need to give it some testing as well but looking good at a glance.
`.trim(); | ||
|
||
// Write all files | ||
const files = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should include a translations file and maybe even put the translation for the label in there as well.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What do you mean @chrisdp? can you explain more?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Gchorba see this doc about using the locale
folder for storing string translations. https://developer.roku.com/en-ca/docs/developer-program/core-concepts/localization.md
Happy to chat more if this doesn't clear things up.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So you suggest modifying the hello world to use the tr("Hello World!") and store the other languages?
Would you rather it be stored as:
- `translations.ts`: TS XML format
- `translations.xml`: XLIFF XML format
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Or are you suggesting also doing the images?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@chrisdp checking on this
Co-authored-by: Christopher Dwyer-Perkins <[email protected]>
Co-authored-by: Christopher Dwyer-Perkins <[email protected]>
Adding the ability to autogenerate a "hello world" template for new developers
Added createNewProject.ts and updated extension.ts and package.json