Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding ability to autogenerate "hello world" template for new developers #621

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

Gchorba
Copy link

@Gchorba Gchorba commented Feb 19, 2025

Adding the ability to autogenerate a "hello world" template for new developers

Added createNewProject.ts and updated extension.ts and package.json

Adds the ability to create a new roku hello world project through the extension
Copy link
Collaborator

@chrisdp chrisdp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small initial pass of review. Need to give it some testing as well but looking good at a glance.

`.trim();

// Write all files
const files = [
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should include a translations file and maybe even put the translation for the label in there as well.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you mean @chrisdp? can you explain more?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Gchorba see this doc about using the locale folder for storing string translations. https://developer.roku.com/en-ca/docs/developer-program/core-concepts/localization.md

Happy to chat more if this doesn't clear things up.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So you suggest modifying the hello world to use the tr("Hello World!") and store the other languages?

Would you rather it be stored as:

  1. `translations.ts`: TS XML format
  2. `translations.xml`: XLIFF XML format

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or are you suggesting also doing the images?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@chrisdp checking on this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants