Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect handling rollbar.init() arguments when using LOGGER in Django. #234

Closed
veryuncommonname opened this issue Mar 8, 2018 · 0 comments
Assignees
Milestone

Comments

@veryuncommonname
Copy link
Contributor

veryuncommonname commented Mar 8, 2018

Hello,

When using rollbar==0.13.18 with django==1.11.11 and passing rollbar via LOGGER, scrub_fields doesn't come as a list; it comes as logging.config.ConvertingList, so in the result dict_merge fall to make a copy of variable and return string '<Uncopyable obj:...' instead of a list.

I see here two possible solutions:

The first is to change dict_merge to correctly process types inherited from list/dict in the case where copy.deepcopy failed.

The second is to obviously handle scrub_fields in rollbar.init().

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants