Obviously handle scrub_fields in rollbar.init()

[veryuncommonname]

My patch for #234

[rokob]

These seems okay to me. I guess I would have set scrub_fields=None instead of =list() but they are equivalent here.

[brianr]

For the original issue (#234), wouldn't this potentially be a problem for every param, not just scrub_fields?

[veryuncommonname]

It will. url_fields will also be affected. The reason of the problem here is dict_merge that can't copy some types. But I think it's not the best solution to change dict_merge in a case where the bug occurs because of arguments for init. Maybe implement a different version of dict_merge for copying settings?

[ediskandarov]

This is potentially dangerous.
It's discouraged to define default argument values with mutable objects.

http://docs.python-guide.org/en/latest/writing/gotchas/#mutable-default-arguments

[veryuncommonname]

Yeah, you are right!

[rokob]

It isn't an issue here because the default isn't used instead it is just a falsey sentinel, but yeah a None would work just as well.

[ediskandarov]

@rokob
You're right, it isn't used now.
But who knows what will be in future.
Can you guarantee next contributor won't overlook that?