Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

httpx 0.28.0 breaks pyrollbar #465

Closed
mchuck opened this issue Jan 9, 2025 · 3 comments · Fixed by #466
Closed

httpx 0.28.0 breaks pyrollbar #465

mchuck opened this issue Jan 9, 2025 · 3 comments · Fixed by #466
Assignees
@danielmorell

Comments

@mchuck
Copy link

mchuck commented Jan 9, 2025

Hi,

It seems that a recent update in the httpx package breaks pyrollbar by removing the previously deprecated proxies parameter.

image

The issue seems to be in this line:

pyrollbar/rollbar/lib/_async.py

Line 137 in a809a6b

async with httpx.AsyncClient(

@linear Linear
Copy link

linear bot commented Jan 9, 2025

SDK-410 httpx 0.28.0 breaks pyrollbar

@brianr
Copy link
Member

brianr commented Jan 9, 2025 •
edited
Loading

Thank you @mchuck! We'll look into this, anticipating to start this week.

@danielmorell danielmorell mentioned this issue Jan 10, 2025
Merged
12 tasks
danielmorell added a commit that referenced this issue Jan 10, 2025
@danielmorell
Merge pull request #466 from rollbar/fixed/issue-465-httpx0.28.0-not-…
6f2386c 
…compatible-with-rollbar-v1

Fixed #465 httpx 0.28.0 not compatible with rollbar v1.
@danielmorell
Copy link
Collaborator

Hey @mchuck, following up here. We just pushed out a release with a fix for this https://pypi.org/project/rollbar/1.1.1/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@danielmorell danielmorell

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixed #465 httpx 0.28.0 not compatible with rollbar v1. rollbar/pyrollbar
3 participants
@brianr @mchuck @danielmorell