make report_exc_info to accept level arg like report_message #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -195,7 +195,7 @@ def report_exc_info(exc_info=None, request=None, extra_data=None, payload_data=N | |||
| exc_info = sys.exc_info() | |||
|
|
|||
| try: | |||
| return _report_exc_info(exc_info, request, extra_data, payload_data) | |||
| return _report_exc_info(exc_info, request, extra_data, payload_data, level=level) | |||
There was a problem hiding this comment.
Instead of modifying the _report_exc_info() signature, I think it would be better to update payload_data in here like so:
if level:
payload_data = payload_data or {}
payload_data['level'] = level
try:
return _report_exc_info(exc_info, request, extra_data, payload_data)
except:
# ...Thoughts?
There was a problem hiding this comment.
I purposely did this to follow report_message's style (where if payload_data['level'] is provided it will override provided level arg). So the order is exception level -> level arg -> payload_data.
|
Thanks for the PR! Just made a small comment, let me know what you think |
|
Merged and pushed to PyPI as version 0.7.4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I didn't realize that report_exc_info didn't actually accept/do anything with
level='info'like report_message,so I added it, and wrote the test.