Use callable() instead of try/except TypeError #319
Conversation
|
As far as I can tell, the CI failures are unrelated to the changes I made. |
|
@denizdogan Try rebasing master. #328 should have fixed the Travis issues. |
denizdogan
force-pushed
the
use-callable-not-exceptions
branch
from
7d84053 to
3f963ac
Compare
|
@waltjones It seems to fail with the message: "Unable to download 3.3 archive. The archive may not exist. Please consider a different version." Just out of curiosity, how long is Rollbar planning on supporting Python 3.3? It reached end-of-life more than two years ago and will no longer receive security updates. |
|
Oh, it seems to work now? Weird. :) |
|
@denizdogan Rollbar will usually continue support for EOL versions if it's feasible to do so, if it's recently EOL, and if there are still people using it. I thought about whether to drop 3.3 yet, but the updates needed to keep it in travis weren't a big deal. Thank you for the PR and the rebase. |
It seemed unnecessary to use try/except TypeError when checking if a value is callable, let me know what you think!