Fix DeprecationWarning #325
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kronion
force-pushed
the
fix-deprecationwarning
branch
from
fecf88c to
1b2edb0
Compare
|
@kronion Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Importing
pyrollbarinto a Django application withwarningsenabled displays aDeprecationWarningcaused by an invalid escape sequence in the docstring. The culprit is a regex pattern being interpreted as a Python escape sequence. The docstring should be a raw string in order to avoid parsing of Python escape sequences, and the example itself should also be updated for the same reason.Test plan:
PYTHONDONTWRITEBYTECODE=true python3 -Wd -m rollbar.contrib.django.middleware.Before patching the change, you should see the following warning: