Support bare wsgi request #55
Conversation
| self.assertEqual(data['url'], 'http://example.com/api/test?format=json¶m1=value1¶m2=value2') | ||
| self.assertEqual(data['user_ip'], '127.0.0.1') | ||
| self.assertDictEqual(data['GET'], {'format': 'json', 'param1': 'value1', 'param2': 'value2'}) | ||
| self.assertDictEqual(data['headers'], {'Connection': 'close', 'Host': 'example.com', 'User-Agent': 'Agent'}) |
There was a problem hiding this comment.
Missing an assertion for the request method
|
Thanks @asnyatkov! See comments above. Generally looks good; will be happy to merge once the tests are passing. |
| 'method': request.get('REQUEST_METHOD'), | ||
| } | ||
| if 'QUERY_STRING' in request: | ||
| request_data['GET'] = urlparse.parse_qs(request['QUERY_STRING'], keep_blank_values=True) |
There was a problem hiding this comment.
This should probably be request_data[request_data['method'].upper()] = ...
There was a problem hiding this comment.
I think it's correct as-is -- the QUERY_STRING is always the "GET" params. POST data goes in the body, not the query string.
There was a problem hiding this comment.
Let's use request_data['query'] to store this data. request_data['GET'] is a bit misleading IMO.
There was a problem hiding this comment.
I just followed what all other request builders do. request_data['GET'] is used in _scrub_request_data.
There was a problem hiding this comment.
Touché. Ok. Leave it as-is since changing this will require a minor version bump.
|
Thanks for the PR. I've tested and this should be good to merge after my comment about the method name. |
| except ValueError: | ||
| length = 0 | ||
| input = request.get('wsgi.input') | ||
| if length and input and input.seekable(): |
There was a problem hiding this comment.
I'm getting the following Exception while POSTing to a simple wsgi server:
AttributeError: '_fileobject' object has no attribute 'seekable'
There was a problem hiding this comment.
I'll add attribute check and a unit test.
#52