Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added ability to send custom stack traces to _ratchet.push #1

Merged
merged 4 commits into from
Dec 13, 2012
Merged

Added ability to send custom stack traces to _ratchet.push #1

merged 4 commits into from
Dec 13, 2012

Conversation

loganvolkers
Copy link
Contributor

I went above and beyond to re-use some methods, and made the object detection work with iframes/popups.

This should also probably be added to the documentation somewhere.

var trace = {
  exception: {'class': 'com.example.ErrorType', 'message': 'Somebody borked my stack trace'},
  frames: [
    {'filename': 'FancyClass.coffee', 'lineno': 104}, 
    {'filename': 'ImportScript.ts', 'lineno': 102},
    {'filename': 'CompiledGwt.java', 'lineno': 102},
    ...
  ]
}
_ratchet.push({_t: 'trace', trace: trace})

@brianr
Copy link
Member

brianr commented Dec 13, 2012

Awesome. Will review and test this tonight.

@ghost ghost assigned brianr Dec 13, 2012
@brianr brianr merged commit abc2836 into rollbar:master Dec 13, 2012
@brianr
Copy link
Member

brianr commented Dec 13, 2012

Aside from the one comment about trace.frames vs. trace.trace, looks good. Make sure to check that in your usage.

Will finish testing and push this out to production tomorrow (pacific time). Thanks again!

@loganvolkers
Copy link
Contributor Author

@brianr I'm using trace.frames, but just blindly copied trace.trace into the comments.

@brianr
Copy link
Member

brianr commented Dec 13, 2012

@loganvolkers ah cool, figured that might've been the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants