Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

don't fail when body is empty #1005

Merged
merged 1 commit into from
Mar 18, 2022
Merged

don't fail when body is empty #1005

merged 1 commit into from
Mar 18, 2022

Conversation

ijsnow
Copy link
Contributor

@ijsnow ijsnow commented Mar 18, 2022

Description of the change

This change prevents an error being thrown by the rollbar sdk in a corner case where it thinks a response should be JSON but it is empty.

Both me and the original author of the fix couldn't cause a test to fail. In my opinion this shouldn't prevent this change from being fixed as it is minimal.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Shortcut stories and GitHub issues (delete irrelevant)

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers assigned
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

@ijsnow ijsnow requested a review from waltjones March 18, 2022 20:18
@waltjones waltjones merged commit cd277ff into rollbar:master Mar 18, 2022
@yjukaku
Copy link
Contributor

yjukaku commented Mar 18, 2022

Awesome, thanks!

@yjukaku
Copy link
Contributor

yjukaku commented Mar 29, 2022

Any ideas on when this change will be released to npm?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: SyntaxError: Unexpected end of JSON input when server response has no body but JSON content type
3 participants