Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default payload keys before the custom transform runs #1078

Merged
merged 1 commit into from
Jan 3, 2023

Conversation

waltjones
Copy link
Contributor

Description of the change

Currently the defaults from the config override the updated values from the user transform function. Instead, the transform should override the defaults.

This PR adds the default payload options in its own step, so that it is present during the user transform.

Type of change

  • Bug fix (non-breaking change that fixes an issue)

Related issues

Fixes
https://app.shortcut.com/rollbar/story/120633/
#1026

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • Issue from task tracker has a link to this pull request
  • Changes have been reviewed by at least one other engineer

Copy link
Contributor

@mudetroit mudetroit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants