add back verbose logging #311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryvirok
reviewed
Jun 12, 2017
| @@ -212,4 +215,16 @@ Queue.prototype._dequeuePendingRequest = function(item) { | |||
| } | |||
| }; | |||
|
|
|||
| Queue.prototype._maybeLog = function(item) { | |||
| if (this.logger && this.options.verbose) { | |||
| var message = _.get(item, 'data.body.trace.exception.message'); | |||
There was a problem hiding this comment.
Should this also handle logging messages which are not part of a trace/trace_chain?
There was a problem hiding this comment.
As far as I can tell,
Line 577 in 7717f62
There was a problem hiding this comment.
Gotcha. If it's easy, I'd like to add verbose logging for messages as well as exceptions. Basically, anytime someone calls one of the top-level API methods which result in a POST.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As far as I can tell, all the verbose option used to do was log to console.error when we are about to log an exception, so this adds that functionality back