feat: option for disabling esbuild (vitejs#475)

close vitejs#456
rolldown · Jul 4, 2020 · 54177b3 · 54177b3
1 parent 808e889
commit 54177b3
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 5 deletions.
diff --git a/src/node/build/index.ts b/src/node/build/index.ts
@@ -93,7 +93,8 @@ export async function createBaseRollupPlugins(
     rollupInputOptions = {},
     transforms = [],
     vueCustomBlockTransforms = {},
-    cssPreprocessOptions
+    cssPreprocessOptions,
+    enableEsbuild = true
   } = options
   const { nodeResolve } = require('@rollup/plugin-node-resolve')
   const dynamicImport = require('rollup-plugin-dynamic-import-variables')
@@ -108,7 +109,9 @@ export async function createBaseRollupPlugins(
     // vite:resolve
     createBuildResolvePlugin(root, resolver),
     // vite:esbuild
-    await createEsbuildPlugin(options.minify === 'esbuild', options.jsx),
+    enableEsbuild
+      ? await createEsbuildPlugin(options.minify === 'esbuild', options.jsx)
+      : null,
     // vue
     require('rollup-plugin-vue')({
       ...options.rollupPluginVueOptions,

diff --git a/src/node/config.ts b/src/node/config.ts
@@ -117,6 +117,11 @@ export interface SharedConfig {
    * CSS preprocess options
    */
   cssPreprocessOptions?: SFCStyleCompileOptions['preprocessOptions']
+  /**
+   * Enable esbuild
+   * @default true
+   */
+  enableEsbuild?: boolean
 }
 
 export interface ServerConfig extends SharedConfig {

diff --git a/src/node/server/index.ts b/src/node/server/index.ts
@@ -54,7 +54,8 @@ export function createServer(config: ServerConfig): Server {
     alias = {},
     transforms = [],
     vueCustomBlockTransforms = {},
-    optimizeDeps = {}
+    optimizeDeps = {},
+    enableEsbuild = true
   } = config
 
   const app = new Koa<State, Context>()
@@ -98,14 +99,14 @@ export function createServer(config: ServerConfig): Server {
       : []),
     vuePlugin,
     cssPlugin,
-    esbuildPlugin,
+    enableEsbuild ? esbuildPlugin : null,
     jsonPlugin,
     assetPathPlugin,
     webWorkerPlugin,
     wasmPlugin,
     serveStaticPlugin
   ]
-  resolvedPlugins.forEach((m) => m(context))
+  resolvedPlugins.forEach((m) => m && m(context))
 
   const listen = server.listen.bind(server)
   server.listen = (async (...args: any[]) => {