chore(repo): add missing prepare script for several packages
#1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shellscape
changed the title
prepare script for several packagesprepare script for several packages
|
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rollup Plugin Name:
babel,data-uri,dynamic-import-vars,html,stripThis PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers: None
Description
This PR adds the missing
preparescript to several packages, so that they will be built upon runningpnpm install. This aligns with the behavior of other packages.Alternatively, this could be solved by having a single
preparescript in the root package, which can then run this command for all projects in the workspace. This approach would prevent accidental inconsistencies from being introduced, such as those mitigated in this PR. It would also remove duplicated code between package scripts.Please do let me know what the preferred solution for this would be, and I will adjust the PR accordingly if required.