feat(html): Allow adding arbitrary HTML to body and head #339

yagebu · 2020-04-27T18:07:53Z

Rollup Plugin Name: `{html}`

This PR contains:

Are tests included?

yes (bugfixes and features will not be merged without tests)
no

Breaking Changes?

yes (breaking changes will not be merged unless absolutely necessary)
no

If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.

List any relevant issue numbers: n/a

Description

I recently started using this plugin and discovered the just merged #308, which allows adding additional <meta> tags to the HTML <head>. This will nearly allow me to get rid of a custom template function for adding a viewport meta tag. However, I'd still need a custom template function to add a <link> for a favicon or a link to a webmanifest.

This PR adds two more options to add arbitrary strings at the end of the head and body tag respectively in the template function. This might be considered bloat of the options of this plugin, but I'd consider them generic and useful enough to be worth the addition.

Also, the first three commits contain a minor refactor to get rid of an eslint-disable and fix up some minor mistakes in the README.

yagebu · 2020-04-27T18:15:17Z

I didn't find out from the READMEs how to update the snapshots, so there's one failing snapshot where I test the new two options. How can I update the snapshots?

shellscape · 2020-04-27T18:57:09Z

Thanks for opening a PR and for your interest in the plugin. I had feared that #308 would be a slippery slope and potentially open us up to people wanting to inject all manner of things into the default document. I was hoping that wouldn't happen, but here we are 😄

I apologize for dismissing this so quickly, but we have to pass on this addition. We'll be directing folks proposing similar features in the future to use the template function. That exists for customization of the default template, and folks should really use that. If repetition over multiple domains is a concern, I'd recommend creating a small package that can be reused across domains that exports the same template function.

Thanks again for your time on this.

yagebu · 2020-04-27T19:18:50Z

As I wrote, I understand that might seem to lead to bloat, but I think you're a bit quick to dismiss it completely. I'd argue for reverting #308 and just adding the head option. It covers the "I need additional tags" and all my use cases (various types of links). Also, for simply adding HTML tags, I think the object syntax of the meta option is more verbose and harder to understand than a simple string.

@mseeley: What do you think? Would your use cases also be addressed by a head option that allows adding a string into the head tag in the template?

shellscape · 2020-04-27T19:21:40Z

Thanks for the reply. I disagree that it was closed too quickly, however. I had already prepared a response should a similar feature be proposed. I'm afraid this isn't one I'm willing to budge on.

yagebu · 2020-04-27T19:32:05Z

Thanks for the reply.

I'm afraid this isn't one I'm willing to budge on.

I'm sad to hear that. I think the meta->head change wouldn't hurt users of the meta option and a net improvement overall.

Thanks for maintaining these plugins!

* initial commit * allow include/exclude * admin and README * -> 1.0.0 * fix prepublish script * Update README.md * make compatible with babel 6 * -> 2.0.0 * Merge pull request rollup#6 from Victorystick/patch-1 Add repository * Merge pull request rollup#8 from TrySound/tidy-up Tidy up * -> 2.0.1 * remove unnecessary logging * bump up timeout, to try and fix tests on 0.12 * generate sourcemaps by default * -> 2.1.0 * test for rollup#16 * run preflight check per file – fixes rollup#16 * -> 2.2.0 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * debug travis test failure * add missing devDep * add appveyor config * es6ify source code * fix tests on windows? * install babel-register * Merge pull request rollup#19 from rollup/rollupgh-17 Better handling of helpers * -> 2.3.0 * -> 2.3.2 * fix incomprehensible travis test failure * fix helper renaming (rollup#22) * -> 2.3.3 * fix failing preflight check in absence of class transformer (closes rollup#23) * -> 2.3.4 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * use class transformer local to plugin * -> 2.3.5 * typo * verify warnings are correct * prevent unnecessary `var babelHelpers = {}` * update rollup * Merge pull request rollup#29 from rollup/fix-preflight-check-caching Ensure caching works properly for repeated calls with the same `dir`. * -> 2.3.6 * remove some debugging code * Merge pull request rollup#31 from ericf/fix-babel-helper-bindings Fix Babel helper binding renaming * -> 2.3.7 * -> 2.3.8 * external-helpers-2 -> external-helpers * Merge remote-tracking branch 'ericf/remove-babel-helper-renaming' * -> 2.3.9 * Update README.md * Merge pull request rollup#41 from joeldenning/external-helpers Adding support for referencing external, global helpers * -> 2.4.0 * import helpers, so that transform function is pure * update test * update deps, switch from babel to buble * -> v2.5.0 * install buble * Merge pull request rollup#57 from rollup/mocha-opts Extract mocha options into their own file. * Merge pull request rollup#56 from rollup/rollupgh-55 typeof * -> v2.5.1 * Update dependencies. * dont export _typeof, _extends etc * use NUL convention for helper name * -> v2.6.0 * -> v2.6.1 * typo * Merge pull request rollup#73 from zeitiger/updateDocumentationForBabel63 update README for new Babel 6.13 * update dependencies * Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing * update build matrix * update appveyor matrix * update babel-preset-es2015-rollup for tests * test with babel-preset-es2015-rollup@3 * Merge pull request rollup#90 from DrewML/update-babel-warning Remove recommendation to change Babel preset from lib * Merge pull request rollup#85 from rollup/use-onwarn-if-available Use options.onwarn if available * Merge pull request rollup#94 from rtsao/patch-1 Updated external-helpers package name in README * Merge pull request rollup#99 from AMcBain/master Ignore Babel 'only' options property for preflight checks. * Merge pull request rollup#92 from sorgloomer/master Added externalHelpersWhitelist option * -> v2.7.0 * Merge pull request rollup#108 from rollup/rollupgh-102 remove ignore from preflight options * Merge pull request rollup#107 from rollup/rollupgh-105 fix duplicated helper warnings with runtime helpers * Merge pull request rollup#109 from rollup/rollupgh-95 Allow custom runtime-helpers moduleName * -> v2.7.1 * -> v2.7.1 * fix prepublish script * Merge pull request rollup#117 from vinkla/patch-1 Simplify repository config * make use of object-assign (rollup#118) Delete assign from utils.js * Breaking: Babel 7 alpha update (rollup#139) Breaking: Babel 7 alpha update * 3.0.0-alpha.12 * update to babel 7 alpha.15 * 3.0.0-alpha.15 * use alpha.17 (rollup#151) * 3.0.0-alpha.17 * Peer dep (rollup#153) * make an inline plugin for the preflight check, make babel-core a peerDep * turn babel-core dep into a peerDep * fix reference to old class plugin * update lock file, ignore log files * 3.0.0 * 3.0.0 changelog [skip ci] * fix transform (rollup#154) * 3.0.1 * changelog [skip ci] * Fix regression with Babel 6 (rollup#158) * Fix regression with Babel 6 Since in Babel 6 it is not supported to replace the argument of a default export declaration with an expression, use a custom "replaceWith" function which handles also that case. Fixes rollup#155, fixes rollup#156. * Run tests using both Babel 7 and Babel 6 * 3.0.2 * Fixed support for babel 7 (rollup#170) * Fixed support for babel 7 * feat(babel): Use scoped babel packages BREAKING CHANGE: This now requires scoped babel packages to be used. * Updated to @babel/plugin-proposal-decorators * Replace es2015 preset with env (rollup#174) * Merge pull request rollup#150 from wmhilton/patch-1 Use "module" in addition to "jsnext:main" * 4.0.0-beta.0 * Merge pull request rollup#175 from rollup/existentialism-patch-1 Fix small grammar nit in external-helpers warning * Update README.md (rollup#163) Added a missing word and fixed few tiny errors * Update rollup dependencies and fix tests and build * merge master -> update-deps * Merge pull request rollup#147 from kopax/master clarify README.md showing an example excluding helpers with a variable set to true * Refactored async tests to bare promises to fix them on older nodes (rollup#194) * Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (rollup#193) * 4.0.0-beta.2 * Restore NUL convention for helper name (rollup#198) The null character `\0` seems to have first been introduced by d169da1. Fixes rollup#197 * 4.0.0-beta.3 * bumped babel deps * 4.0.0-beta.4 * Fix npm beta label in README (rollup#207) Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta". * Bumped version of babel deps * Tweaked preflight check (fixes rollup#211) * 4.0.0-beta.5 * Drop node@4 support * Bumped all dependencies. (rollup#219) * Update pinned version of babel. * Update all development dependencies so this plugin is tested against current software. * Make changes to test needed by updated rollup. * Add node.js 10 to testing. * Delegate warnings and errors reporting to rollup (rollup#223) * Delegate warnings and errors reporting to rollup * Fixed mocha deprecation warn * Merge branch 'option-cleanup' * Cache preflight check results per plugin's instance (rollup#224) * Merge remote-tracking branch 'miketrexler/modules-false-docs' * Tweaked babelrc: false workaround recommendation * Throw when used with module transform BEFORE throwing about unexpected situation (rollup#225) * Updated deps: eslint, rollup, pluginutils - tests still green * Fix for issue rollup#220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage. * Fine-tuned runtime check to allow custom helper name. Issue rollup#220. * Added new previously failing test for issue rollup#220. * Made hints related to babel modules:false more explicit and helpful. * Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting. * Removed irrelevant babel plugin from a test case * 4.0.0-beta.6 * Fixed runtime helpers detection with useESModules & useBuiltIns options (rollup#226) * Add support for esm and builtin runtime helpers This diff adds support for `useESModules` and `useBuiltIns` options in transform-runtime plugin which injects paths with `es6` and `builtin` suffixes. * Fix lint * 4.0.0-beta.7 * Improve distributed dist directory (rollup#234) * Improve dist - rename .es.js to .esm.js - removed jsnext:main - simplified rollup config * Tweak files and revert external * Upgrade babel deps and tweak preflight check according to latest changes (rollup#233) * Upgrade babel and tweak according changes - simplified preflight check for runtime helpers - removed moduleName test - tweaked removed options * Fix lint * Regenerate lockfile * 4.0.0-beta.8 * Transpile only default babel extensions, allow for custom extensions option (fixes rollup#111) * Pass appropriate caller config to babel.transform (rollup#238) * 4.0.0 * Update docs regarding babel versions and matching plugin versions * Bumped babel deps * 4.0.1 * Fix `rollup` peer dependency (rollup#240) Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof. * 4.0.2 * Tweaked README, added 4.0 CHANGELOG notes * Fixed fallbackClassTransform * 4.0.3-0 * 4.0.3 * Fix preflightChecks for ignored files * Setup prettier * Run prettier over the repo files * Tweak eslint rules to stop conflicting with prettier output * 4.1.0-0 * Add options.extensions to README (rollup#256) * Upgraded husky * Remove babel 6 test from AppVeyor (rollup#263) * Remove babel 6 test from appveyor * Remove reduntant echo * Fix indentation in examples of configuration in readme (rollup#266) * Return null from the transform hook when it doesn't transform anything * 4.1.0-1 * 4.1.0 * Reword 'except' as 'plus' (rollup#280) * Allow rollup@1 as peer dep * 4.2.0 * Update devDep to rollup@1 * Fail build when trying plugin tries to add non-existent helper (rollup#290) * Merge branch 'custom-builder' * 4.3.0 * Fix reference to the plugin in the README * Update CHANGELOG * Add js extention to helper file (rollup#296) * 4.3.1 * Add note to CHANGELOG about v4.3.1 * Fix usage with externalHelpers flag * 4.3.2 * Update CHANGELOG with note about 4.3.2 * chore: audit fixes * chore: npm audit fix * Update [email protected] (rollup#311) * Update [email protected] Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability. https://nodesecurity.io/advisories/786 * Regenerate package-lock * 4.3.3 * Add possibility to run babel per output (rollup#333) * Update dependencies * First draft for using the plugin to transform output options * Deduplicate code * Pass correct context to transformCode * Update documentation and add chunking test * Fix Windows tests * Address review comments * No longer respect "file" and "dir" options and adjust docs * Use plugin.generated for output plugin * Add warning for formats other than ESM or CJS, update docs * Throw for not recommended formats but add an override option. * Address review comments * Fixed issue with incorrect caller data being passed to Babel by generated output plugins * Reduce information about external helpers as those are not recommended * Add `sourceType` when transforming the output. * Update test and readme for runtime helpers * Add note about babelrc files * Do not load config files by default * Update dependencies * Note minimal Rollup version for output plugins * Merge branch 'tla' # Conflicts: # src/index.js * Use babel.transformAsync (rollup#331) * Use rimraf in prebuild script (rollup#335) * use rimraf * move to dev dep * Drop node 6 support, use untranspiled async/await syntax * Recommend explicit babelHelpers option to be used (rollup#339) * Refactored babelHelpers settings - require user declaring which kind of helpers they want to use * Adjust tests to new babelHelpers logic * Keep UNRESOLVED_IMPORT warnings out of the console when running tests * 5.0.0-alpha.0 * Rename skipBabelHelpersCheck to skipPreflightCheck * Make missing babelHelpers a warning * 5.0.0-alpha.1 * Use transformAsync in preflight check * Tweak implementation of the preflight helpers check * Add example to the README how to use the plugin with the Rollup CLI (rollup#327) * explain how to configure the rollup cli * Tweak README * Dont crash on minified code when performing preflight check * Rename rollup-plugin-babel directory to babel * Remove tooling configs not needed in monorepo * Drop transpilation of rollup-plugin-babel, set engines to node@>=10 * Reformat babel plugin with monorepo prettier & ESLint rules * Use exports: named for babel plugin CJS bundle * Migrate babel plugin tests to use ava * Use pnpm to run npm scripts in babel plugin * Use scoped @rollup/plugin-json in babel plugin * Remove unnecessary eslint-disable comment * Update babel plugin metadata to point to monorepo * Remove LICENSE file from babel plugin, pnpm will use the root one when publishing * Move .eslints with turned off rules to fixtures directory * Move loop counter declaration * use getCode helper where possible * Use more proper throwsAsync & notThrowsAsync assertions * Transpile @rollup/plugin-babel using itself * Migrate to use @rollup/pluginutils in babel plugin * Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins * Fix homepage in babel plugin package.json * Include repository reference in test descriptionbs refering to issue numbers * Change URLs in the source files to point to a plugins repo * Change rollup-plugin-babel to @rollup/plugin-babel in source files * cleanup README a little bit * Tweak "Modules" section, remove mentions of Babel 6 from there * Fix some more references to rollup-plugin-babel * Add badges to the top of the README * Adhere to the README template used by other plugins * Tweak CHANGELOG * Mention Babel plugin in the root README * Add publishConfig to package.json of the Babel plugin * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <[email protected]> * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <[email protected]> * Fixed how @rollup/pluginutils are used * Allow Rollup 2 in peer dependency range * Refactor babel plugin exports shape * tweak usage example in the babel plugin README * Align package.json of Babel plugin to existing package.json files in the monorepo * Update @rollup/pluginutils in the Babel plugin * Add new changelog entries to the Babel plugin * Move babelHelpers recommendation text to the README * Fix typo in the README * chore: remove prepare script, build in prepublishOnly This avoids fresh `pnpm install` problems where the build runs before babel plugins are installed. * Upgrade @babel/preset-env in babel plugin Co-authored-by: Rich-Harris <[email protected]> Co-authored-by: Oskar Segersvärd <[email protected]> Co-authored-by: Brian Donovan <[email protected]> Co-authored-by: Yuta Hiroto <[email protected]> Co-authored-by: Henry Zhu <[email protected]> Co-authored-by: Nicolò Ribaudo <[email protected]> Co-authored-by: Denis <[email protected]> Co-authored-by: Daniel Tschinder <[email protected]> Co-authored-by: Brian Ng <[email protected]> Co-authored-by: Roy Revelt <[email protected]> Co-authored-by: Minh Nguyen <[email protected]> Co-authored-by: Can Göktas <[email protected]> Co-authored-by: Corey Farrell <[email protected]> Co-authored-by: Sebastian Werner <[email protected]> Co-authored-by: Bogdan Chadkin <[email protected]> Co-authored-by: ylemkimon <[email protected]> Co-authored-by: Kristoffer <[email protected]> Co-authored-by: Shadab Khan <[email protected]> Co-authored-by: Adam Gołąb <[email protected]> Co-authored-by: Kinrany <[email protected]> Co-authored-by: Mike Heddes <[email protected]> Co-authored-by: shellscape <[email protected]> Co-authored-by: Ryan Walters <[email protected]> Co-authored-by: Lukas Taegert-Atkinson <[email protected]> Co-authored-by: Troy Rhinehart <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Tiger Oakes <[email protected]>

vperron · 2020-05-04T21:57:18Z

I'm also very interested in something close to this. I'm trying to use rollup as a new build environment for SPAs and this HTML plugin proves quite frustrating to customize :)

A patch enabling the customization of meta tags a few days ago was most welcome and enabled me to have a viewport-ready HTML. There was just no way to insert those, unless entirely redefining the template function in my own code and all of its internal code to transform "files" into "links" and "scripts".

My new issue is to add something as basic as a favicon to my HTML. Any feature that would let me add links, or any tags to the head would be so useful. I think that is a sad and hard limitation.

I see maybe two way outs there:

either add "links" and "scripts", array-based configuration entries, just like the "meta" one that has just been added;
change the template function signature to include directly "links" and "scripts" instead of the "bundle" and "files" entries. This way we could just add tags on the fly and call the original function to do the job properly.

What do you think ? I could contribute either one of those.

shellscape · 2020-05-05T01:21:25Z

Neither of those options are very appealing to me. The default template (

plugins/packages/html/lib/index.js

Lines 27 to 61 in 233c7c1

    
           const defaultTemplate = async ({ attributes, files, meta, publicPath, title }) => { 
        
             const scripts = (files.js || []) 
        
               .map(({ fileName }) => { 
        
                 const attrs = makeHtmlAttributes(attributes.script); 
        
                 return `<script src="${publicPath}${fileName}"${attrs}></script>`; 
        
               }) 
        
               .join('\n'); 
        
             const links = (files.css || []) 
        
               .map(({ fileName }) => { 
        
                 const attrs = makeHtmlAttributes(attributes.link); 
        
                 return `<link href="${publicPath}${fileName}" rel="stylesheet"${attrs}>`; 
        
               }) 
        
               .join('\n'); 
        
             const metas = meta 
        
               .map((input) => { 
        
                 const attrs = makeHtmlAttributes(input); 
        
                 return `<meta${attrs}>`; 
        
               }) 
        
               .join('\n'); 
        
             return ` 
        
           <!doctype html> 
        
           <html${makeHtmlAttributes(attributes.html)}> 
        
             <head> 
        
               ${metas} 
        
               <title>${title}</title> 
        
               ${links} 
        
             </head> 
        
             <body> 
        
               ${scripts} 
        
             </body> 
        
           </html>`; 
        
           };

) isn't very complicated, nor are the methods for placing files, links, and the rest. Our html plugin follows the minimalistic nature of mini-html-webpack-plugin, and I spoke with the author at length about the ideas behind offering a different html plugin for webpack.

This boils down to a difference in ideology: "make every possible allowance for the user" vs "provide a simple baseline and empower the user to meet their needs". You'll notice this a lot when comparing webpack and its components to rollup and its components. We don't want to get into the business of trying to meet every single user need with specific features for each one of those needs. Instead, we try to provide a reasonable default baseline, and make sure we have the right features in place to let users extend that to their heart's content.

If the html plugin isn't doing it for you, there are a few more listed here: https://github.com/rollup/awesome that might prove to meet your wants a little better. (We maintain that list to lift other plugin and utility authors up, even without them being official plugins).

That said, there won't be any more extensions to the template function option made in the near future. If exporting any of the plugin's internal methods would aid you in building your custom template, please open a separate issue and we can talk about making that happen.

* initial commit * allow include/exclude * admin and README * -> 1.0.0 * fix prepublish script * Update README.md * make compatible with babel 6 * -> 2.0.0 * Merge pull request rollup#6 from Victorystick/patch-1 Add repository * Merge pull request rollup#8 from TrySound/tidy-up Tidy up * -> 2.0.1 * remove unnecessary logging * bump up timeout, to try and fix tests on 0.12 * generate sourcemaps by default * -> 2.1.0 * test for rollup#16 * run preflight check per file – fixes rollup#16 * -> 2.2.0 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * debug travis test failure * add missing devDep * add appveyor config * es6ify source code * fix tests on windows? * install babel-register * Merge pull request rollup#19 from rollup/rollupgh-17 Better handling of helpers * -> 2.3.0 * -> 2.3.2 * fix incomprehensible travis test failure * fix helper renaming (rollup#22) * -> 2.3.3 * fix failing preflight check in absence of class transformer (closes rollup#23) * -> 2.3.4 * Merge branch 'master' of https://github.com/rollup/rollup-plugin-babel * use class transformer local to plugin * -> 2.3.5 * typo * verify warnings are correct * prevent unnecessary `var babelHelpers = {}` * update rollup * Merge pull request rollup#29 from rollup/fix-preflight-check-caching Ensure caching works properly for repeated calls with the same `dir`. * -> 2.3.6 * remove some debugging code * Merge pull request rollup#31 from ericf/fix-babel-helper-bindings Fix Babel helper binding renaming * -> 2.3.7 * -> 2.3.8 * external-helpers-2 -> external-helpers * Merge remote-tracking branch 'ericf/remove-babel-helper-renaming' * -> 2.3.9 * Update README.md * Merge pull request rollup#41 from joeldenning/external-helpers Adding support for referencing external, global helpers * -> 2.4.0 * import helpers, so that transform function is pure * update test * update deps, switch from babel to buble * -> v2.5.0 * install buble * Merge pull request rollup#57 from rollup/mocha-opts Extract mocha options into their own file. * Merge pull request rollup#56 from rollup/rollupgh-55 typeof * -> v2.5.1 * Update dependencies. * dont export _typeof, _extends etc * use NUL convention for helper name * -> v2.6.0 * -> v2.6.1 * typo * Merge pull request rollup#73 from zeitiger/updateDocumentationForBabel63 update README for new Babel 6.13 * update dependencies * Merge branch 'issue/81-generates-sourcemap-by-default-spec-failing' of https://github.com/snuggs/rollup-plugin-babel into snuggs-issue/81-generates-sourcemap-by-default-spec-failing * update build matrix * update appveyor matrix * update babel-preset-es2015-rollup for tests * test with babel-preset-es2015-rollup@3 * Merge pull request rollup#90 from DrewML/update-babel-warning Remove recommendation to change Babel preset from lib * Merge pull request rollup#85 from rollup/use-onwarn-if-available Use options.onwarn if available * Merge pull request rollup#94 from rtsao/patch-1 Updated external-helpers package name in README * Merge pull request rollup#99 from AMcBain/master Ignore Babel 'only' options property for preflight checks. * Merge pull request rollup#92 from sorgloomer/master Added externalHelpersWhitelist option * -> v2.7.0 * Merge pull request rollup#108 from rollup/rollupgh-102 remove ignore from preflight options * Merge pull request rollup#107 from rollup/rollupgh-105 fix duplicated helper warnings with runtime helpers * Merge pull request rollup#109 from rollup/rollupgh-95 Allow custom runtime-helpers moduleName * -> v2.7.1 * -> v2.7.1 * fix prepublish script * Merge pull request rollup#117 from vinkla/patch-1 Simplify repository config * make use of object-assign (rollup#118) Delete assign from utils.js * Breaking: Babel 7 alpha update (rollup#139) Breaking: Babel 7 alpha update * 3.0.0-alpha.12 * update to babel 7 alpha.15 * 3.0.0-alpha.15 * use alpha.17 (rollup#151) * 3.0.0-alpha.17 * Peer dep (rollup#153) * make an inline plugin for the preflight check, make babel-core a peerDep * turn babel-core dep into a peerDep * fix reference to old class plugin * update lock file, ignore log files * 3.0.0 * 3.0.0 changelog [skip ci] * fix transform (rollup#154) * 3.0.1 * changelog [skip ci] * Fix regression with Babel 6 (rollup#158) * Fix regression with Babel 6 Since in Babel 6 it is not supported to replace the argument of a default export declaration with an expression, use a custom "replaceWith" function which handles also that case. Fixes rollup#155, fixes rollup#156. * Run tests using both Babel 7 and Babel 6 * 3.0.2 * Fixed support for babel 7 (rollup#170) * Fixed support for babel 7 * feat(babel): Use scoped babel packages BREAKING CHANGE: This now requires scoped babel packages to be used. * Updated to @babel/plugin-proposal-decorators * Replace es2015 preset with env (rollup#174) * Merge pull request rollup#150 from wmhilton/patch-1 Use "module" in addition to "jsnext:main" * 4.0.0-beta.0 * Merge pull request rollup#175 from rollup/existentialism-patch-1 Fix small grammar nit in external-helpers warning * Update README.md (rollup#163) Added a missing word and fixed few tiny errors * Update rollup dependencies and fix tests and build * merge master -> update-deps * Merge pull request rollup#147 from kopax/master clarify README.md showing an example excluding helpers with a variable set to true * Refactored async tests to bare promises to fix them on older nodes (rollup#194) * Fixed issue with reading .code from null (untranspiled file due to ignore/only options) (rollup#193) * 4.0.0-beta.2 * Restore NUL convention for helper name (rollup#198) The null character `\0` seems to have first been introduced by d169da1. Fixes rollup#197 * 4.0.0-beta.3 * bumped babel deps * 4.0.0-beta.4 * Fix npm beta label in README (rollup#207) Previously, the instructions for usage with Babel 7 was to install the plugin with the label "next" which doesn't exist. The correct label is "beta". * Bumped version of babel deps * Tweaked preflight check (fixes rollup#211) * 4.0.0-beta.5 * Drop node@4 support * Bumped all dependencies. (rollup#219) * Update pinned version of babel. * Update all development dependencies so this plugin is tested against current software. * Make changes to test needed by updated rollup. * Add node.js 10 to testing. * Delegate warnings and errors reporting to rollup (rollup#223) * Delegate warnings and errors reporting to rollup * Fixed mocha deprecation warn * Merge branch 'option-cleanup' * Cache preflight check results per plugin's instance (rollup#224) * Merge remote-tracking branch 'miketrexler/modules-false-docs' * Tweaked babelrc: false workaround recommendation * Throw when used with module transform BEFORE throwing about unexpected situation (rollup#225) * Updated deps: eslint, rollup, pluginutils - tests still green * Fix for issue rollup#220: Check ESM first before checking inheritance helper + Expect imported package instead of variable name which feels safer for checking runtime usage. * Fine-tuned runtime check to allow custom helper name. Issue rollup#220. * Added new previously failing test for issue rollup#220. * Made hints related to babel modules:false more explicit and helpful. * Extracted error messages into variables, splitted by lines for better code readability. Template literals are not allowed right now by linting. * Removed irrelevant babel plugin from a test case * 4.0.0-beta.6 * Fixed runtime helpers detection with useESModules & useBuiltIns options (rollup#226) * Add support for esm and builtin runtime helpers This diff adds support for `useESModules` and `useBuiltIns` options in transform-runtime plugin which injects paths with `es6` and `builtin` suffixes. * Fix lint * 4.0.0-beta.7 * Improve distributed dist directory (rollup#234) * Improve dist - rename .es.js to .esm.js - removed jsnext:main - simplified rollup config * Tweak files and revert external * Upgrade babel deps and tweak preflight check according to latest changes (rollup#233) * Upgrade babel and tweak according changes - simplified preflight check for runtime helpers - removed moduleName test - tweaked removed options * Fix lint * Regenerate lockfile * 4.0.0-beta.8 * Transpile only default babel extensions, allow for custom extensions option (fixes rollup#111) * Pass appropriate caller config to babel.transform (rollup#238) * 4.0.0 * Update docs regarding babel versions and matching plugin versions * Bumped babel deps * 4.0.1 * Fix `rollup` peer dependency (rollup#240) Semver range `^0.60.0` doesn't include `0.65.0`, etc., as if major version is 0, minor version updates indicate breaking changes. `>1` is added for future-proof. * 4.0.2 * Tweaked README, added 4.0 CHANGELOG notes * Fixed fallbackClassTransform * 4.0.3-0 * 4.0.3 * Fix preflightChecks for ignored files * Setup prettier * Run prettier over the repo files * Tweak eslint rules to stop conflicting with prettier output * 4.1.0-0 * Add options.extensions to README (rollup#256) * Upgraded husky * Remove babel 6 test from AppVeyor (rollup#263) * Remove babel 6 test from appveyor * Remove reduntant echo * Fix indentation in examples of configuration in readme (rollup#266) * Return null from the transform hook when it doesn't transform anything * 4.1.0-1 * 4.1.0 * Reword 'except' as 'plus' (rollup#280) * Allow rollup@1 as peer dep * 4.2.0 * Update devDep to rollup@1 * Fail build when trying plugin tries to add non-existent helper (rollup#290) * Merge branch 'custom-builder' * 4.3.0 * Fix reference to the plugin in the README * Update CHANGELOG * Add js extention to helper file (rollup#296) * 4.3.1 * Add note to CHANGELOG about v4.3.1 * Fix usage with externalHelpers flag * 4.3.2 * Update CHANGELOG with note about 4.3.2 * chore: audit fixes * chore: npm audit fix * Update [email protected] (rollup#311) * Update [email protected] Update `rollup-pluginutils` to a version which contains a fix for the `braces` package vulnerability. https://nodesecurity.io/advisories/786 * Regenerate package-lock * 4.3.3 * Add possibility to run babel per output (rollup#333) * Update dependencies * First draft for using the plugin to transform output options * Deduplicate code * Pass correct context to transformCode * Update documentation and add chunking test * Fix Windows tests * Address review comments * No longer respect "file" and "dir" options and adjust docs * Use plugin.generated for output plugin * Add warning for formats other than ESM or CJS, update docs * Throw for not recommended formats but add an override option. * Address review comments * Fixed issue with incorrect caller data being passed to Babel by generated output plugins * Reduce information about external helpers as those are not recommended * Add `sourceType` when transforming the output. * Update test and readme for runtime helpers * Add note about babelrc files * Do not load config files by default * Update dependencies * Note minimal Rollup version for output plugins * Merge branch 'tla' # Conflicts: # src/index.js * Use babel.transformAsync (rollup#331) * Use rimraf in prebuild script (rollup#335) * use rimraf * move to dev dep * Drop node 6 support, use untranspiled async/await syntax * Recommend explicit babelHelpers option to be used (rollup#339) * Refactored babelHelpers settings - require user declaring which kind of helpers they want to use * Adjust tests to new babelHelpers logic * Keep UNRESOLVED_IMPORT warnings out of the console when running tests * 5.0.0-alpha.0 * Rename skipBabelHelpersCheck to skipPreflightCheck * Make missing babelHelpers a warning * 5.0.0-alpha.1 * Use transformAsync in preflight check * Tweak implementation of the preflight helpers check * Add example to the README how to use the plugin with the Rollup CLI (rollup#327) * explain how to configure the rollup cli * Tweak README * Dont crash on minified code when performing preflight check * Rename rollup-plugin-babel directory to babel * Remove tooling configs not needed in monorepo * Drop transpilation of rollup-plugin-babel, set engines to node@>=10 * Reformat babel plugin with monorepo prettier & ESLint rules * Use exports: named for babel plugin CJS bundle * Migrate babel plugin tests to use ava * Use pnpm to run npm scripts in babel plugin * Use scoped @rollup/plugin-json in babel plugin * Remove unnecessary eslint-disable comment * Update babel plugin metadata to point to monorepo * Remove LICENSE file from babel plugin, pnpm will use the root one when publishing * Move .eslints with turned off rules to fixtures directory * Move loop counter declaration * use getCode helper where possible * Use more proper throwsAsync & notThrowsAsync assertions * Transpile @rollup/plugin-babel using itself * Migrate to use @rollup/pluginutils in babel plugin * Set peer dep range for rollup to ^1.20.0 to align with the rest of plugins * Fix homepage in babel plugin package.json * Include repository reference in test descriptionbs refering to issue numbers * Change URLs in the source files to point to a plugins repo * Change rollup-plugin-babel to @rollup/plugin-babel in source files * cleanup README a little bit * Tweak "Modules" section, remove mentions of Babel 6 from there * Fix some more references to rollup-plugin-babel * Add badges to the top of the README * Adhere to the README template used by other plugins * Tweak CHANGELOG * Mention Babel plugin in the root README * Add publishConfig to package.json of the Babel plugin * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <[email protected]> * Update packages/babel/README.md Co-Authored-By: Tiger Oakes <[email protected]> * Fixed how @rollup/pluginutils are used * Allow Rollup 2 in peer dependency range * Refactor babel plugin exports shape * tweak usage example in the babel plugin README * Align package.json of Babel plugin to existing package.json files in the monorepo * Update @rollup/pluginutils in the Babel plugin * Add new changelog entries to the Babel plugin * Move babelHelpers recommendation text to the README * Fix typo in the README * chore: remove prepare script, build in prepublishOnly This avoids fresh `pnpm install` problems where the build runs before babel plugins are installed. * Upgrade @babel/preset-env in babel plugin Co-authored-by: Rich-Harris <[email protected]> Co-authored-by: Oskar Segersvärd <[email protected]> Co-authored-by: Brian Donovan <[email protected]> Co-authored-by: Yuta Hiroto <[email protected]> Co-authored-by: Henry Zhu <[email protected]> Co-authored-by: Nicolò Ribaudo <[email protected]> Co-authored-by: Denis <[email protected]> Co-authored-by: Daniel Tschinder <[email protected]> Co-authored-by: Brian Ng <[email protected]> Co-authored-by: Roy Revelt <[email protected]> Co-authored-by: Minh Nguyen <[email protected]> Co-authored-by: Can Göktas <[email protected]> Co-authored-by: Corey Farrell <[email protected]> Co-authored-by: Sebastian Werner <[email protected]> Co-authored-by: Bogdan Chadkin <[email protected]> Co-authored-by: ylemkimon <[email protected]> Co-authored-by: Kristoffer <[email protected]> Co-authored-by: Shadab Khan <[email protected]> Co-authored-by: Adam Gołąb <[email protected]> Co-authored-by: Kinrany <[email protected]> Co-authored-by: Mike Heddes <[email protected]> Co-authored-by: shellscape <[email protected]> Co-authored-by: Ryan Walters <[email protected]> Co-authored-by: Lukas Taegert-Atkinson <[email protected]> Co-authored-by: Troy Rhinehart <[email protected]> Co-authored-by: Josh Soref <[email protected]> Co-authored-by: Tiger Oakes <[email protected]>

yagebu added 4 commits April 27, 2020 19:39

chore: fixup html plugin readme

d21db1d

fix(html): remove eslint-disable; improve helper func

c49ca2f

chore(html): fix type description

ce0cd0b

feat(html): add body and head options to insert extra HTML

c999c0e

shellscape closed this Apr 27, 2020

shellscape added pr³ 🔧 feature x⁸ ⋅ wontfix 🔌 plugin-html labels Apr 27, 2020

yagebu mentioned this pull request Apr 27, 2020

refactor(html): remove eslint disable #340

Closed

9 tasks

yagebu deleted the html-extras branch April 27, 2020 19:32

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(html): Allow adding arbitrary HTML to body and head #339

feat(html): Allow adding arbitrary HTML to body and head #339

yagebu commented Apr 27, 2020

yagebu commented Apr 27, 2020

shellscape commented Apr 27, 2020

yagebu commented Apr 27, 2020

shellscape commented Apr 27, 2020

yagebu commented Apr 27, 2020

vperron commented May 4, 2020

shellscape commented May 5, 2020

feat(html): Allow adding arbitrary HTML to body and head #339

feat(html): Allow adding arbitrary HTML to body and head #339

Conversation

yagebu commented Apr 27, 2020

Rollup Plugin Name: {html}

Description

yagebu commented Apr 27, 2020

shellscape commented Apr 27, 2020

yagebu commented Apr 27, 2020

shellscape commented Apr 27, 2020

yagebu commented Apr 27, 2020

vperron commented May 4, 2020

shellscape commented May 5, 2020

Rollup Plugin Name: `{html}`