-
-
Notifications
You must be signed in to change notification settings - Fork 599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(inject): isReference check bug #804
Conversation
inject plugin, test is reference
isReference test
Please provide a detailed description of why this change is necessary, and any relevant issue numbers. (If there isn't an issue associated with this PR, you'll have to provide a good amount of information about the problem you were trying to solve.) |
bar
in import { bar as foo }
Is there ANY description of what this is about? |
@danielgindi @shellscape I add more description. |
@danielgindi how's that update to the PR description look for you? |
Not the best, but getting there. If I understand correctly, there's a situation where an import is not flagged correctly and it causes duplicate imports in the output, resulting in a syntax error. |
@danielgindi I believe that's correct. Going to move this one forward. |
* disregard the `bar` in `import { bar as foo } * isReference test
Rollup Plugin Name:
inject
This PR contains:
Are tests included?
Breaking Changes?
If yes, then include "BREAKING CHANGES:" in the first commit message body, followed by a description of what is breaking.
List any relevant issue numbers:
Description
disregard the bar in import { bar as foo }
For example
If my config inject "bar", the following code
will transfrom to the following code
.
But expect will not inject.