This repository has been archived by the owner on Aug 4, 2021. It is now read-only.
Ensure caching works properly for repeated calls with the same dir.
#29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`preflightCheck` tries to cache its results, but it did so in a way that is incorrect. It works fine with a cache miss, but a cache hit results in resetting the cache to `undefined`.
Rich-Harris
added a commit
that referenced
this pull request
Jan 5, 2016
Ensure caching works properly for repeated calls with the same `dir`.
|
nice, thanks – I wonder if this is the cause of #26 as well. Will push out a new release so we can find out |
|
@Rich-Harris looks like it fixed the issue for me both in decaffeinate and esnext. Thanks for the release! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
preflightChecktries to cache its results, but it did so in a way that is incorrect. It works fine with a cache miss, but a cache hit results in resetting the cache toundefined.This is the ultimate cause of decaffeinate/decaffeinate#106.