Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

0.46.3+ Type error. #1547

Closed
cebor opened this issue Aug 12, 2017 · 1 comment · Fixed by #1548
Closed

0.46.3+ Type error. #1547

cebor opened this issue Aug 12, 2017 · 1 comment · Fixed by #1548
Labels
t¹ 🐞 bug

Comments

@cebor
Copy link

cebor commented Aug 12, 2017 •
edited
Loading

Since 0.46.3 i get following error when compiling my angular library:

build/angular-highcharts.js → dist/angular-highcharts.js...
[!] TypeError: declaration.module.getExports is not a function
TypeError: declaration.module.getExports is not a function
    at addDeclaration (/Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:8094:25)
    at /Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:8103:5
    at Array.forEach (<anonymous>)
    at /Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:8102:34
    at /Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:127:57
    at Array.forEach (<anonymous>)
    at forOwn (/Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:127:24)
    at ModuleScope.deshadow (/Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:8089:3)
    at /Users/felix/code/angular-highcharts/node_modules/rollup/dist/rollup.js:5908:57
    at Array.forEach (<anonymous>)

Repo: https://github.com/cebor/angular-highcharts (build.sh)

With 0.46.2 all works fine.
Rich-Harris added a commit that referenced this issue Aug 12, 2017
@Rich-Harris
ignore external namespace imports when deshadowing - fixes #1547
f85ffe8
@Rich-Harris Rich-Harris mentioned this issue Aug 12, 2017
Merged
Rich-Harris added a commit that referenced this issue Aug 12, 2017
@Rich-Harris
Merge pull request #1548 from rollup/gh-1547
1ccf54d 
ignore external namespace imports when deshadowing
@Rich-Harris
Copy link
Contributor

Thanks — this is fixed in 0.47.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
t¹ 🐞 bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

ignore external namespace imports when deshadowing rollup/rollup
2 participants
@Rich-Harris @cebor