-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds support for Promises returned in config, fixes #1503 #1731
Adds support for Promises returned in config, fixes #1503 #1731
Conversation
cc: @Rich-Harris, @lukastaegert let me know if you still want this feature. Thanks :) |
@ankeetmaini Yes, I find this VERY interesting! During JS Kongress this week I learned a lot about people using rollup in very creative ways to build very complex pipelines and I am sure those people would love this functionality. |
@lukastaegert thanks so much! I'm interested in contributing to Rollup, is there an architecture note on how to understand the codebase? |
Unfortunately not yet and, to be honest, things are a little in flux especially regarding the core tree-shaking algorithm. I hope to be able to write something up once things have settled down a little but probably not too soon. 👍🎉 for people who want to contribute! If you want some ideas where to go next:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! You might want to remove the file I marked. Beyond that, I plan on merging this into the next non-patch release!
@@ -0,0 +1,11 @@ | |||
(function (global, factory) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Including this file does not have an effect as it is only checked if you do NOT set execute: true
in _config.js
. You should remove it as it is rather confusing (and while you are at it, remove it from the cli/config
test as well 😜)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You got it!
17fcbb8
to
8c5bdd4
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! I'll put it into the next feature release.
BTW we should document this on the web site. If someone were to prepare a PR for https://github.com/rollup/rollupjs.org that describes this feature and at the same time also addresses rollup/rollupjs.org#69, that would be awesome! |
I'll take a look! |
I have started to assemble a branch for the next release but it will take another few days until I release it because I there are a few more PRs I want to have in there which are not ready yet. |
This PR is raised against #1503.