ensure name suggestions are legal identifiers #696
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug exposed by rollup/rollup-plugin-babel#55 – it's possible for a module to export a binding that is a reserved word, and for another module to import that reserved word, without ever writing a syntax error...
(The export from
helpers.js
might be against spec, I'm not sure. That would be a separate issue if it is.)This PR ensures that the use of
helpers.typeof
doesn't cause thevar _typeof
to be rewritten asvar typeof
.