feat: allow reusing CondVar object during CondVar::notify_all()

romange · Oct 19, 2024 · e590cc7 · e590cc7
1 parent 5719e24
commit e590cc7
Showing 1 changed file with 8 additions and 2 deletions.
diff --git a/util/fibers/synchronization.h b/util/fibers/synchronization.h
@@ -161,8 +161,14 @@ class CondVarAny {
   }
 
   void notify_all() noexcept {
-    if (!wait_queue_.empty())
-      wait_queue_.NotifyAll(detail::FiberActive());
+    if (!wait_queue_.empty()) {
+      detail::WaitQueue tmp_queue;
+      // this allows reusing CondVarAny object during WaitQueue::NotifyAll() execution
+      // if another thread decided to wait again on this object
+      std::swap(tmp_queue, wait_queue_);
+      tmp_queue.NotifyAll(detail::FiberActive());
+    }
+
   }
 
   template <typename LockType> void wait(LockType& lt);