Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: non constant expression in array size #368

Merged
merged 1 commit into from
Jan 15, 2025
Merged

Conversation

kostasrim
Copy link
Contributor

Expression of the form int arr[SOME_NON_CONSTANT] are illegal by the C++ standard yet compilers support it as an extension. Let's not use that and use vector instead. On the bonus side we also now don't have a warning.

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.91%. Comparing base (d30de86) to head (2eae231).
Report is 138 commits behind head on master.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #368      +/-   ##
==========================================
+ Coverage   77.60%   77.91%   +0.30%     
==========================================
  Files         103      108       +5     
  Lines        7824     8950    +1126     
==========================================
+ Hits         6072     6973     +901     
- Misses       1752     1977     +225     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@romange romange merged commit 8805a09 into romange:master Jan 15, 2025
5 checks passed
@kostasrim kostasrim deleted the kpr1 branch January 31, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants